fix: wait before compress and normalize pidstat CPU values - #61
Merged
Conversation
Add wait after killing collector processes so they finish flushing data to disk before xz compression starts. Without the wait, the last sample could be corrupted or truncated. Also fix "sysstst" typo in error message, add -r flag to while read, and quote the filename variable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pidstat reports CPU percentages in 0-100 range but mpstat normalizes to 0-1 for the same Busy-CPU/NonBusy-CPU metric types. Divide by 100 to match mpstat's convention. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
atheurer
approved these changes
Jul 9, 2026
atheurer
left a comment
atheurer
left a comment
Contributor
There was a problem hiding this comment.
The pidstat /100 normalization is important — CPU values were 100x inflated in CDM. Wait-before-compress and the typo fix are good too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitafter killing collector processes before xz compression to prevent corrupting the last sample-rflag towhile read, quote filename variableTest plan
crucible runwith sysstat tool completes — verify compressed output is not truncatedResolves #60
🤖 Generated with Claude Code